[PATCH V3] PM / core: fix deferred probe breaking suspend resume order

Rafael J. Wysocki rjw at rjwysocki.net
Thu Apr 5 09:38:30 PDT 2018


On Wednesday, April 4, 2018 11:10:41 PM CEST Feng Kan wrote:
> On Fri, Mar 30, 2018 at 3:50 PM, Bjorn Helgaas <helgaas at kernel.org> wrote:
> > On Thu, Mar 15, 2018 at 11:41:33AM -0700, Feng Kan wrote:
> >> On Mon, Mar 5, 2018 at 10:29 AM, Feng Kan <fkan at apm.com> wrote:
> >> > When bridge and its endpoint is enumerated the devices are added to the
> >> > dpm list. Afterward, the bridge defers probe when IOMMU is not ready.
> >> > This causes the bridge to be moved to the end of the dpm list when
> >> > deferred probe kicks in. The order of the dpm list for bridge and
> >> > endpoint is reversed.
> >> >
> >> > Add reordering code to move the bridge and its children and consumers to
> >> > the end of the pm list so the order for suspend and resume is not altered.
> >> > The code also move device and its children and consumers to the tail of
> >> > device_kset list if it is registered.
> >> >
> >> > Signed-off-by: Feng Kan <fkan at apm.com>
> >> > Signed-off-by: Toan Le <toanle at apm.com>
> >> > ...
> >> >
> >> Hi, just wanted to check if there is anything else I need to change on
> >> this. Thanks.
> >
> > I'm assuming Rafael will handle this.
> Rafael, sorry to ping again. Do you have a position on this patch yet?

Sorry, I thought that Greg might want to send a comment here.

I'm basically fine with the approach.  I only have two minor remarks to the
kernedoc comment of the new function, but let me reply directly to the patch
message.




More information about the linux-arm-kernel mailing list