[PATCH 1/2] coresight: Use %px to print pcsr instead of %p

Kees Cook keescook at chromium.org
Wed Apr 4 23:26:04 PDT 2018


On Tue, Mar 13, 2018 at 10:24 AM, Mathieu Poirier
<mathieu.poirier at linaro.org> wrote:
> From: Leo Yan <leo.yan at linaro.org>
>
> Commit ad67b74d2469 ("printk: hash addresses printed with %p") lets
> printk specifier %p to hash all addresses before printing, this was
> resulting in the high 32 bits of pcsr can only output zeros.  So
> module cannot completely print pc value and it's pointless for debugging
> purpose.
>
> This patch fixes this by using %px to print pcsr instead.

Why is %p (and now %px) needed here at all? %pS is already used, which
should give useful debugging details, yes?

-Kees

-- 
Kees Cook
Pixel Security



More information about the linux-arm-kernel mailing list