[PATCH v6 0/3] add support for Socionext SynQuacer I2C controller

[Ard Biesheuvel]

On 3 April 2018 at 17:01, Wolfram Sang <wsa at the-dreams.de> wrote:
>
>> - switch to generic recovery using minimal helpers to drive the SDA/SCL lines
>>   directly
>
> If you had added this incrementally, reviewing would have been easier (=
> faster). The callbacks look okay...
>
>> - don't recover on every error
>
> ... but you are now never recovering. You don't call i2c_recover_bus().
>

Yeah, good point. So when exactly should this be called? Only on error
conditions that could be caused by a misbehaving slave?

>> - add patch to sanity check i2c_transfer() arguments in core code (#3)
>
> See small comment there.
>