[PATCH] tty: amba-pl011: Report AUTOCTS capability to framework

Stefan Wahren stefan.wahren at i2se.com
Mon Oct 30 16:46:53 PDT 2017


Hi Lukas,

> Lukas Wunner <lukas at wunner.de> hat am 31. Oktober 2017 um 00:32 geschrieben:
> 
> 
> On Mon, Oct 30, 2017 at 11:24:31PM +0000, Stefan Wahren wrote:
> > --- a/drivers/tty/serial/amba-pl011.c
> > +++ b/drivers/tty/serial/amba-pl011.c
> > @@ -2029,9 +2029,11 @@ pl011_set_termios(struct uart_port *port, struct ktermios *termios,
> >  
> >  		old_cr |= UART011_CR_CTSEN;
> >  		uap->autorts = true;
> > +		port->status |= UPSTAT_AUTOCTS;
> >  	} else {
> >  		old_cr &= ~(UART011_CR_CTSEN | UART011_CR_RTSEN);
> >  		uap->autorts = false;
> > +		port->status &= ~UPSTAT_AUTOCTS;
> >  	}
> >  
> >  	if (uap->vendor->oversampling) {
> 
> Don't you also need to clear the UPSTAT_AUTOCTS bit in pl011_disable_uart()?
> 
> FWIW I posted a patch to linux-serial on Oct 25 which subsumes the above
> patch, would that work for you?
> 
> https://marc.info/?l=linux-serial&m=150891880104614&w=4

sorry for missing your patch. Mine should be ignored.

> 
> Thanks,
> 
> Lukas



More information about the linux-arm-kernel mailing list