[PATCH] PCI: exynos: remove redundant code in exynos_pcie_establish_link

[Krzysztof Kozlowski]

On Mon, Oct 9, 2017 at 4:14 PM, Pankaj Dubey <pankaj.dubey at samsung.com> wrote:
> From: Anvesh Salveru <anvesh.s at samsung.com>
>
> In exynos_pcie_establish_link if driver is not using generic phy,
> we are resetting PHY twice, which is redundant, so this patch removes

Hi Pankaj,

This lacks the information why it is redundant.

> repeated lines of code for PHY reset.
>
> Signed-off-by: Anvesh Salveru <anvesh.s at samsung.com>

Your Signed-off-by is needed here.

Best regards,
Krzysztof

> ---
>  drivers/pci/dwc/pci-exynos.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-exynos.c b/drivers/pci/dwc/pci-exynos.c
> index 5596fde..85d2f4b 100644
> --- a/drivers/pci/dwc/pci-exynos.c
> +++ b/drivers/pci/dwc/pci-exynos.c
> @@ -423,13 +423,6 @@ static int exynos_pcie_establish_link(struct exynos_pcie *ep)
>                 exynos_pcie_deassert_phy_reset(ep);
>                 exynos_pcie_power_on_phy(ep);
>                 exynos_pcie_init_phy(ep);
> -
> -               /* pulse for common reset */
> -               exynos_pcie_writel(ep->mem_res->block_base, 1,
> -                                       PCIE_PHY_COMMON_RESET);
> -               udelay(500);
> -               exynos_pcie_writel(ep->mem_res->block_base, 0,
> -                                       PCIE_PHY_COMMON_RESET);
>         }
>
>         /* pulse for common reset */
> --
> 2.7.4
>