[PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

Jassi Brar jassisinghbrar at gmail.com
Fri Oct 6 04:26:01 PDT 2017


On Wed, Oct 4, 2017 at 5:06 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla <sudeep.holla at arm.com> wrote:
>> This patch adds ARM MHU specific mailbox interface for SCMI.
>>
>> Cc: Arnd Bergmann <arnd at arndb.de>
>> Signed-off-by: Sudeep Holla <sudeep.holla at arm.com>
>
> This clearly needs an explanation why we need another driver.
>
Yes the patch needs explanation which is that we need a shim layer to
map SCMI requests onto what the underlying controller expects. The
alternative was to clone the controller driver (MHU now and others
later when their platforms support SCMI) and pretend SCMI is the only
client they are ever going to serve.

BTW, I haven't reviewed this patchset yet so I am not sure about this
code but I do believe we need a transport layer (this shim driver)
between generic SCMI implementation and each controller driver.



More information about the linux-arm-kernel mailing list