[PATCH 13/20] ARM: dts: sun4i: Remove gpio-keys warnings

Maxime Ripard maxime.ripard at free-electrons.com
Fri Oct 6 02:27:57 PDT 2017


On Thu, Oct 05, 2017 at 03:51:02PM +0000, Chen-Yu Tsai wrote:
> On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard
> <maxime.ripard at free-electrons.com> wrote:
> > Some gpio-keys definitions in our DTs were having buttons defined with a
> > unit-address and that would generate a DTC warning.
> >
> > Change the buttons node names to remove the warnings.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> > ---
> >  arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 40 ++++++++++-----------
> >  arch/arm/boot/dts/sun4i-a10-pcduino.dts      |  6 +--
> >  2 files changed, 23 insertions(+), 23 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> > index 7c7f12132ea3..13224f5ac166 100644
> > --- a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> > +++ b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> > @@ -67,7 +67,7 @@
> >                 #size-cells = <0>;
> >                 poll-interval = <20>;
> >
> > -               button at 0 {
> > +               left-joystick-left {
> 
> Does this fit the naming scheme? Should we have "-button" suffices?

The example binding of gpio-keys just have the key name as node name,
just like most of the DT out there I could find.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171006/d3bce6e6/attachment.sig>


More information about the linux-arm-kernel mailing list