[PATCH 2/8] ARM: dts: aspeed: Reorder ADC node

Andrew Jeffery andrew at aj.id.au
Tue Oct 3 22:21:30 PDT 2017


On Wed, 2017-10-04 at 14:43 +0930, Joel Stanley wrote:
> > > > > > +                     adc: adc at 1e6e9000 {
> > > +                             compatible = "aspeed,ast2500-adc";
> > > +                             reg = <0x1e6e9000 0xb0>;
> > 
> > Did you intend to change the size cell value here? It now matches the g4, but
> > there was an explicit comment about the size for some reason in the -hunk
> > below. It's probably worth an explicit call-out if we're going to change it.
> 
> Looks ok to me.

Yeah, sorry, was looking in the wrong spot :/

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171004/26ad933b/attachment.sig>


More information about the linux-arm-kernel mailing list