[PATCH] ARM64: PCI: Fix struct acpi_pci_root_ops allocation failure path

Catalin Marinas catalin.marinas at arm.com
Thu May 25 08:53:26 PDT 2017


On Mon, May 22, 2017 at 04:48:28PM +0100, Lorenzo Pieralisi wrote:
> From: Timmy Li <lixiaoping3 at huawei.com>
> 
> Commit 093d24a20442 ("arm64: PCI: Manage controller-specific data on
> per-controller basis") added code to allocate ACPI PCI root_ops
> dynamically on a per host bridge basis but failed to update the
> corresponding memory allocation failure path in pci_acpi_scan_root()
> leading to a potential memory leakage.
> 
> Fix it by adding the required kfree call.
> 
> Fixes: 093d24a20442 ("arm64: PCI: Manage controller-specific data on per-controller basis")
> Signed-off-by: Timmy Li <lixiaoping3 at huawei.com>
> [lorenzo.pieralisi at arm.com: refactored code, rewrote commit log]
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>
> CC: Will Deacon <will.deacon at arm.com>
> CC: Bjorn Helgaas <bhelgaas at google.com>
> Cc: Catalin Marinas <catalin.marinas at arm.com>
> Cc: Tomasz Nowicki <tn at semihalf.com>

I queued the patch for 4.12. Thanks.

-- 
Catalin



More information about the linux-arm-kernel mailing list