[PATCH] arm64: cpufeature: Make ID reg accessor naming less counterintuitive

Suzuki K Poulose Suzuki.Poulose at arm.com
Fri Mar 24 10:36:15 PDT 2017


On 23/03/17 15:14, Dave Martin wrote:
> read_system_reg() can readily be confused with read_sysreg(),
> whereas these are really quite different in their meaning.
>
> This patches attempts to reduce the ambiguity be reserving "sysreg"
> for the actual system register accessors.
>
> read_system_reg() is instead renamed to read_sanitised_ftr_reg(),
> to make it more obvious that the Linux-defined sanitised feature
> register cache is being accessed here, not the underlying
> architectural system registers.
>
> cpufeature.c's internal __raw_read_system_reg() function is renamed
> in line with its actual purpose: a form of read_sysreg() that
> indexes on (non-compiletime-constant) encoding rather than symbolic
> register name.
>
> Signed-off-by: Dave Martin <Dave.Martin at arm.com>
>

Thanks for clean up !

Reviewed-by: Suzuki K Poulose <suzuki.poulose at arm.com>




More information about the linux-arm-kernel mailing list