[PATCH] tee: add forward declaration for struct device

Jens Wiklander jens.wiklander at linaro.org
Wed Jun 14 02:46:11 PDT 2017


On Wed, Jun 14, 2017 at 11:39:50AM +0200, Jerome Forissier wrote:
> [+Arnd]
> 
> Ping?
> 
> Thanks,
> -- 
> Jerome
> 
> On 05/31/2017 01:21 PM, Jerome Forissier wrote:
> > tee_drv.h references struct device, but does not include device.h nor
> > platform_device.h. Therefore, if tee_drv.h is included by some file
> > that does not pull device.h nor platform_device.h beforehand, we have a
> > compile warning. Fix this by adding a forward declaration.
> > 
> > Signed-off-by: Jerome Forissier <jerome.forissier at linaro.org>
> > ---
> >  include/linux/tee_drv.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h
> > index 8614713..07bd226 100644
> > --- a/include/linux/tee_drv.h
> > +++ b/include/linux/tee_drv.h
> > @@ -29,6 +29,7 @@
> >  #define TEE_SHM_DMA_BUF		BIT(1)	/* Memory with dma-buf handle */
> >  #define TEE_SHM_EXT_DMA_BUF	BIT(2)	/* Memory with dma-buf handle */
> >  
> > +struct device;
> >  struct tee_device;
> >  struct tee_shm;
> >  struct tee_shm_pool;
> > 

Looks good to me.

Reviewed-by: Jens Wiklander <jens.wiklander at linaro.org>

--
Thanks,
Jens



More information about the linux-arm-kernel mailing list