[RFT PATCH v2 33/42] PCI: iproc: Drop pci_fixup_irqs()

Lorenzo Pieralisi lorenzo.pieralisi at arm.com
Thu Jun 8 07:13:33 PDT 2017


Since, through struct pci_host_bridge.map/swizzle_irq hooks, IRQs
are now allocated in the pci_assign_irq() callback automatically,
PCI host bridge drivers can stop relying on pci_fixup_irqs()
for IRQ allocation.

Drop pci_fixup_irqs() usage from PCI iproc host bridge driver.

Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>
Cc: Scott Branden <sbranden at broadcom.com>
Cc: Bjorn Helgaas <bhelgaas at google.com>
Cc: Ray Jui <rjui at broadcom.com>
Cc: Jon Mason <jonmason at broadcom.com>
---
 drivers/pci/host/pcie-iproc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c
index 55a3665..c574863 100644
--- a/drivers/pci/host/pcie-iproc.c
+++ b/drivers/pci/host/pcie-iproc.c
@@ -1324,6 +1324,8 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res)
 	host->dev.parent = dev;
 	host->ops = &iproc_pcie_ops;
 	host->sysdata = sysdata;
+	host->map_irq = pcie->map_irq;
+	host->swizzle_irq = pci_common_swizzle;
 
 	ret = pci_scan_root_bus_bridge(host);
 	if (ret < 0) {
@@ -1331,9 +1333,6 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res)
 		goto err_power_off_phy;
 	}
 
-	if (pcie->map_irq)
-		pci_fixup_irqs(pci_common_swizzle, pcie->map_irq);
-
 	pci_assign_unassigned_bus_resources(host->bus);
 
 	pcie->root_bus = host->bus;
-- 
2.10.0




More information about the linux-arm-kernel mailing list