Small issue with 3fde2999fac5 "arm64: cpufeature: Don't dump useless backtrace on CPU_OUT_OF_SPEC"

Mark Rutland mark.rutland at arm.com
Mon Jun 5 02:24:39 PDT 2017


On Mon, Jun 05, 2017 at 11:20:53AM +0200, Heiner Kallweit wrote:
> Am 05.06.2017 um 10:48 schrieb Mark Rutland:
> > Hi,
> > 
> > On Sun, Jun 04, 2017 at 02:53:36PM +0200, Heiner Kallweit wrote:
> >> The warning is printed unconditionally. An "if (taint)" seems to be
> >> missing.
> > 
> > I'm not sure I follow. We're using pr_warn_once(), which should only
> > print the message once, regardless of how many times it is called.
> > 
> Before we had WARN_TAINT_ONCE(taint, ..), so the warning is
> triggered by taint != 0.
> Now the warning is printed (just once but) even if taint == 0.

Ah, I see.

Thanks for the report; I'll put together a fix shortly.

Do you mind if I add:

Reported-by: Heiner Kallweit <hkallweit1 at gmail.com>

... to that patch?

Thanks,
Mark.



More information about the linux-arm-kernel mailing list