[PATCH] iio: adc: xilinx: Fix error handling

Christophe JAILLET christophe.jaillet at wanadoo.fr
Mon Feb 20 12:25:58 PST 2017


Le 20/02/2017 à 09:35, Lars-Peter Clausen a écrit :
> On 02/19/2017 09:29 PM, Christophe JAILLET wrote:
>> Reorder error handling labels in order to match the way resources have
>> been allocated.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
> Thanks, looks good.
>
> Acked-by: Lars-Peter Clausen <lars at metafoo.de>
>
> I think there is one more issue
>
>      ret = xadc->ops->setup(pdev, indio_dev, irq);
>      if (ret)
>          goto err_free_samplerate_trigger;
>
> should be
>
> 	goto err_clk_disable_unprepare;
>
I agree.

Would you like me to send a V2 with both fixes or a sepparate patch?

CJ





More information about the linux-arm-kernel mailing list