[PATCH 0/3] drivers/perf: arm_pmu: rework IRQ management

Mark Rutland mark.rutland at arm.com
Fri Feb 10 03:05:20 PST 2017


For historical reasons, we lazily request and free interrupts in the
arm_pmu driver, managing affinity at request time. Unfortunately, this
is not well balanced w.r.t. CPU hotplug, resulting in a number of
issues.

This series addresses this by reworking the way we manage interrupts,
splitting request/free from affinity management. This renders some code
redundant, and said code is removed.

I've given this a spin on a Juno R1 system, a Cortex-A9 based system, and
another system which uses PPIs. I've verified that the IRQ affinity is as
expected after CPUs are brought online. I've also run basic perf queries and
the perf fuzzer, both in parallel with random hotplug events.

Since v1 [1]:
* Free resources correctly.
* Remove unused fields from struct arm_pmu.
* Improve messages when parsing IRQs.

Since v2 [2]:
* Fix broken pdev handling
* Improve probe-time error reporting

Thanks,
Mark.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/484285.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-February/485610.html

Mark Rutland (3):
  drivers/perf: arm_pmu: rework per-cpu allocation
  drivers/perf: arm_pmu: manage interrupts per-cpu
  drivers/perf: arm_pmu: split irq request from enable

 drivers/perf/arm_pmu.c       | 487 +++++++++++++++++++++----------------------
 include/linux/perf/arm_pmu.h |   7 +-
 2 files changed, 237 insertions(+), 257 deletions(-)

-- 
1.9.1




More information about the linux-arm-kernel mailing list