[PATCH 0/7 v2] net: Fix platform_get_irq's error checking

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Tue Dec 5 01:57:41 PST 2017


On 12/5/2017 12:54 PM, Sergei Shtylyov wrote:

>> The platform_get_irq() function returns negative number if an error
>> occurs, Zero if No irq is found and positive number if irq gets successful.
> 
>     No, returning 0 is not a failure indication anymore! It used to be but not 
> any longer...

    And I fixed this function exactly to avoid overly complex error checks 
(which you're trying to propose here).

>> platform_get_irq() error checking for only zero is not correct.
> 
> [...]

MBR, Sergei



More information about the linux-arm-kernel mailing list