[linux-sunxi] Re: [PATCH v2] mmc: sunxi: Fix NULL pointer reference on clk_delays

[icenowy at aosc.io]

在 2017-08-08 15:10，Chen-Yu Tsai 写道：
> On Tue, Aug 8, 2017 at 3:07 PM,  <icenowy at aosc.io> wrote:
>> 在 2017-08-08 15:02，Chen-Yu Tsai 写道：
>>> 
>>> Some SoCs do not support clk delays for MMC in the clock control 
>>> unit.
>>> These include the old controllers in A10/A10s/A13/R8, and the new 
>>> eMMC
>>> controller in A64. The config structure for these controllers do not
>>> specify clk_delays, but the check for this was replaced in commit
>>> b0600daebf31 ("mmc: sunxi: Support controllers that can use both old
>>> and new timings").
>>> 
>>> This patch adds back the check for clk_delays, and also adds comments
>>> for both checks in sunxi_mmc_clk_set_phase().
>>> 
>>> Fixes: b0600daebf31 ("mmc: sunxi: Support controllers that can use
>>>                       both old and new timings")
>>> Signed-off-by: Chen-Yu Tsai <wens at csie.org>
>> 
>> 
>> Should I add a Tested-by here?
> 
> If you tested it, then yes. :)

I tested it on A64 MMC2.

So:

Tested-by: Icenowy Zheng <icenowy at aosc.io>

> 
> ChenYu