[PATCH v3 1/3] tty: amba-pl011: define flag register bits for ZTE device

Shawn Guo shawnguo at kernel.org
Fri Sep 16 22:37:53 PDT 2016


On Fri, Sep 16, 2016 at 12:11:05PM -0500, Timur Tabi wrote:
> Russell King - ARM Linux wrote:
> >Maybe what we should've done with ZTE is insisted that they implement
> >a complete new driver, rather than trying to shoe-horn it into PL011
> >even though it is in theory PL011.
> 
> When I suggested that a year ago, I was shot down:
> 
> http://www.spinics.net/lists/arm-kernel/msg455888.html

I still think that's a bad idea.  ZTE is not the first one making such
small customization on PL011, and likely won't be the last one.  We
don't want to clone PL011 driver every time there is a such vendor
hardware coming out, do we?  Having PL011 driver being able to handle
different register layout is very helpful to handle such vendor
variants, IMHO.

I still appreciate rmk's insistence to handle ZTE device with PL011
driver, and the effort of adding a little "infrastructure" to handle
all such possible variants.

Shawn



More information about the linux-arm-kernel mailing list