[PATCH] pwm: atmel-hlcdc: Fix default PWM polarity

Thierry Reding thierry.reding at gmail.com
Tue May 17 04:00:05 PDT 2016


On Tue, May 17, 2016 at 11:12:32AM +0200, Boris Brezillon wrote:
> The PWM device exposed by the HLCDC IP is configured with an inverted
> polarity by default. Registering the PWM chip with the normal polarity
> was not a problem before commit 42e8992c58d4 ("pwm: Add core
> infrastructure to allow atomic updates") because the ->set_polarity()
> hook was called no matter the current polarity state, but this is no longer
> the case.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> Fixes: 42e8992c58d4 ("pwm: Add core infrastructure to allow atomic updates")

That's not technically correct, because it's the driver that has the
bug. The core change merely exposes it. How about if I sort this into
the pwm-atomic branch and reword the commit message accordingly? That
way things should all stay bisectible.

Then again, given the breakage caused by the pwm_args patch I suppose
it doesn't matter much because that's part of a stable branch that I
can't rebase.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160517/ed5f4534/attachment.sig>


More information about the linux-arm-kernel mailing list