dmaengine: ARM pl080 misidentified as Samsung pl080s

[Tomasz Figa]

2016-03-24 11:56 GMT+01:00 Johannes Stezenbach <js at sig21.net>:
> Hi,
>
> commit da1b6c05b8b5bd ("dmaengine: PL08x: Add support for PL080S variant")
> added this hunk:
>
>  static struct amba_id pl08x_ids[] = {
> +       /* Samsung PL080S variant */
> +       {
> +               .id     = 0x0a141080,
> +               .mask   = 0xffffffff,
> +               .data   = &vendor_pl080s,
> +       },
>         /* PL080 */
>
> However, 0x0a141080 happens to be the ID of the
> ARM PL080, too:
> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0196g/I54627.html

It can be, assuming that 0xa1 is an existing revision of original
PL080. AFAIK when we were figuring out what to do with this broken
Samsung's controller, we found out that there was no platform with
such revision. Is your concern related to any actual hardware already
supported by upstream?

Best regards,
Tomasz

>
> Since the PL080S has the configuration register at a different
> address the driver doesn't work for ARM PL080 anymore.
>
>
> Johannes