[PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219

Xing Zheng zhengxing at rock-chips.com
Tue Jun 7 05:47:01 PDT 2016


Hi Mark,

On 2016年06月07日 20:06, Mark Brown wrote:
> OK, then the original name probably makes some sense though really
> that's such an unusual design that just naming it after the specific
> board might be better, it's not likely to see any reuse I'd guess.
There are not only one type of board with this audio connection, so I 
think we don't need to add specific board name.

Therefore, I intend to recover original name 
(rk3399_max98357a_rt5514_da7219.c), and description like this:
sound {
     compatible = "rockchip,rk3399-max98357a-rt5514-da7219";
     rockchip,cpu = <&i2s0 &i2s0 &i2s0>;               // note (will not 
be sent to upstream): In future, we may use the i2s1 or i2s2...
     rockchip,codec = <&max98357a &headsetcodec &codec>;
};

Could you please agree to do this?

Thanks.

-- 
- Xing Zheng





More information about the linux-arm-kernel mailing list