[RFC PATCH 0/4] arm64: vdso: check whether the params is invalid address

Will Deacon will.deacon at arm.com
Mon Jun 6 10:12:48 PDT 2016


On Wed, Jun 01, 2016 at 11:05:58AM +0800, Yang Yingliang wrote:
> The params of gettimeofday(), clock_gettime() and clock_getres()
> is not checked. This will cause segment faults when the address is
> invalid. 
> E.g. gettimeofday(-1, -1);
>      clock_gettime(0, -1);
>      clock_getres(0, -1);
> This patchset add a macro and use it to check the validation of these
> pointer params.

Is this really necessary? It doesn't look to me like other architectures
bother with this, and you're just adding code to the fastpath to handle
cases that shouldn't happen to start with.

Also, I think I remember seeing SEGVs from libc wrappers for other syscalls
in the past, so this just isn't compelling to me.

Will



More information about the linux-arm-kernel mailing list