RE: [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle

MyungJoo Ham myungjoo.ham at samsung.com
Tue Jul 5 19:47:45 PDT 2016


> 
> --------- Original Message ---------
> Sender : Peter Chen <peter.chen at nxp.com>
> Date   : 2016-07-01 18:49 (GMT+9)
> Title  : [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle
>  
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>  
> Cc: Chanwoo Choi <cw00.choi at samsung.com>
> Cc: MyungJoo Ham <myungjoo.ham at samsung.com>
> Cc: Kyungmin Park <kyungmin.park at samsung.com>
> Cc: Kukjin Kim <kgene at kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> Signed-off-by: Peter Chen <peter.chen at nxp.com>

With the change (build error fix) of the following added, (I'll update)
Signed-off-by: MyungJoo Ham <myungjoo.ham at samsung.com>


Cheers,
MyungJoo

> ---
>  drivers/devfreq/exynos-bus.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>  
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 2363d0a..a38b5ec 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -383,7 +383,7 @@ err_clk:
>  static int exynos_bus_probe(struct platform_device *pdev)
>  {
>          struct device *dev = &pdev->dev;
> -        struct device_node *np = dev->of_node;
> +        struct device_node *np = dev->of_node, node;

+	struct device_node *np = dev->of_node, *node;

>          struct devfreq_dev_profile *profile;
>          struct devfreq_simple_ondemand_data *ondemand_data;
>          struct devfreq_passive_data *passive_data;
...


More information about the linux-arm-kernel mailing list