[PATCH] drm/mediatek: fix error handling

Matthias Brugger matthias.bgg at gmail.com
Sat Jul 2 22:51:31 PDT 2016



On 07/03/2016 07:37 AM, Christophe JAILLET wrote:
> This is likely that checking 'phy_provider' instead of 'phy' is
> expected here.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
> ---
>  drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> index cf8f38d..1c366f8 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> @@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
>  	phy_set_drvdata(phy, mipi_tx);
>
>  	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> -	if (IS_ERR(phy)) {
> +	if (IS_ERR(phy_provider)) {

Dan already send a patch for that:
http://www.spinics.net/lists/dri-devel/msg112031.html

Regards,
Matthias

>  		ret = PTR_ERR(phy_provider);
>  		return ret;
>  	}
>



More information about the linux-arm-kernel mailing list