[PATCH] bus: imx-weim: Take the 'status' property value into account

Fabio Estevam festevam at gmail.com
Mon Feb 22 04:01:53 PST 2016


From: Fabio Estevam <fabio.estevam at nxp.com>

Currently we have an incorrect behaviour when multiple devices
are present under the weim node. For example:

&weim {
	...
	status = "okay";
	
	sram at 0,0 {
		...
        	status = "okay";
	};

	mram at 0,0 {
		...
        	status = "disabled";
    	};
};

In this case only the 'sram' device should be probed and not 'mram'.

However what happens currently is that the status variable is ignored,
causing the 'sram' device to be disabled and 'mram' to be enabled.  

Change the weim_parse_dt() function to use
for_each_available_child_of_node()so that the devices marked with
'status = disabled' are not probed.

Cc: <stable at vger.kernel.org>
Suggested-by: Wolfgang Netbal <wolfgang.netbal at sigmatek.at>
Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
---
 drivers/bus/imx-weim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index e98d15e..1827fc4 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -150,7 +150,7 @@ static int __init weim_parse_dt(struct platform_device *pdev,
 			return ret;
 	}
 
-	for_each_child_of_node(pdev->dev.of_node, child) {
+	for_each_available_child_of_node(pdev->dev.of_node, child) {
 		if (!child->name)
 			continue;
 
-- 
1.9.1




More information about the linux-arm-kernel mailing list