[PATCH] coresight: etb: Remove simple announcement message

Mark Brown broonie at kernel.org
Fri Feb 12 13:54:28 PST 2016


On Fri, Feb 12, 2016 at 01:44:31PM -0700, Mathieu Poirier wrote:
> On 11 February 2016 at 05:50, Mark Brown <broonie at kernel.org> wrote:

> > -       dev_info(dev, "ETB initialized\n");
> >         return 0;

> Didn't we touch base on that topic before?  I'm not against moving

We did and you said that there was a patch pending which would change it
to print something useful but the patch still applies so I guess that
didn't happen.

> forward with this but it has to be all or nothing - whether we remove
> all the CS boot log message or they all stay.  Otherwise people could
> mistakenly come to the conclusion that some of the CS components did
> not boot properly.

> ETB, funnel and TMCs don't output any useful HW related information
> but tracers (ETMv3, PTM and ETMv4) actually do.

I think people are familiar enough with the general policy on this stuff
to be able to cope with this, it's certainly not something that's ever
come up with ASoC where we do have a similar multi-device structure.

> People concerned about boot time will definitely set their loglevel
> accordingly on the kernel cmd line.  Otherwise we are likely talking
> about developers interested in knowing what happened when their kernel
> booted.

That applies equally to all drivers so from that point of view we should
be doing something in the driver core - there is actually some logging
there that can be enabled, though it's not that widely used.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160212/4aa128c5/attachment.sig>


More information about the linux-arm-kernel mailing list