[PATCH V2 6/6] coresight-stm: adding driver for CoreSight STM component

Alexander Shishkin alexander.shishkin at linux.intel.com
Fri Feb 5 05:06:20 PST 2016


Chunyan Zhang <zhang.chunyan at linaro.org> writes:

> +#ifndef CONFIG_64BIT
> +static inline void __raw_writeq(u64 val, volatile void __iomem *addr)
> +{
> +	asm volatile("strd %1, %0"
> +		     : "+Qo" (*(volatile u64 __force *)addr)
> +		     : "r" (val));
> +}

Is it really ok to do this for all !64bit arms, inside a driver, just
like that? I'm not an expert, but I'm pretty sure there's more to it.

Regards,
--
Alex



More information about the linux-arm-kernel mailing list