[PATCH] net: mvpp2: fix dma unmapping of TX buffers for fragments

David Miller davem at davemloft.net
Sat Dec 17 08:35:48 PST 2016


From: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Date: Sat, 17 Dec 2016 16:26:58 +0100

> Yes, I was thinking of moving towards a single array, as it's indeed
> crazy to have three arrays for that. However, since it's a fix going
> into stable, I also wanted to keep it as simple/straightforward as
> possible and avoid refactoring other parts of the code.

By the same token, by adding a third array you are making the code
more complex, adding more error recovery paths, etc.

> If you however believe moving to one array should be done as part of
> the fix, I'll do this.

Please do.



More information about the linux-arm-kernel mailing list