[PATCH 1/3] rtc: armada38x: improve RTC errata implementation

Andrew Lunn andrew at lunn.ch
Thu Dec 8 09:29:23 PST 2016


> +struct str_value_to_freq {
> +	unsigned long value;
> +	u8 freq;
> +} __packed;
> +
> +static unsigned long read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg)
> +{
> +	unsigned long value_array[SAMPLE_NR], i, j, value;
> +	unsigned long max = 0, index_max = SAMPLE_NR - 1;
> +	struct str_value_to_freq value_to_freq[SAMPLE_NR];

Hi Gregory

This appears to be putting over 900 bytes on the stack. Is there any
danger of overflowing the stack? Would it be safer to make these
arrays part of armada38x_rtc?

       Andrew



More information about the linux-arm-kernel mailing list