[PATCH] drivers/perf: arm-pmu: Fix handling of SPI lacking "interrupt-affinity" property

Kevin Hilman khilman at baylibre.com
Fri Aug 26 10:11:55 PDT 2016


Hi Marc,

On Tue, Jul 19, 2016 at 9:39 AM, Marc Zyngier <marc.zyngier at arm.com> wrote:
> Patch 19a469a58720 ("drivers/perf: arm-pmu: Handle per-interrupt
> affinity mask") added support for partitionned PPI setups, but
> inadvertently broke setups using SPIs without the "interrupt-affinity"
> property (which is the case for UP platforms).
>
> This patch restore the broken functionnality by testing whether the
> interrupt is percpu or not instead of relying on the using_spi flag
> that really means "SPI *and* interrupt-affinity property".
>
> Reported-by: Geert Uytterhoeven <geert at linux-m68k.org>
> Tested-by: Geert Uytterhoeven <geert at linux-m68k.org>
> Fixes: 19a469a58720 ("drivers/perf: arm-pmu: Handle per-interrupt affinity mask")
> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>

kernelci.org detected boot failures on bcm2835-rpi-b in mainline[1]
and was bisected down to this patch.  I verified that reverting this
patch on top of mainline gets bcm2835-rpi-b booting again.

I haven't been closely tracking this change, but a quick glance and it
looks like this platform is possibly missing IRQ properties from its
PMU node?  The DT for this platform simply has:

        arm-pmu {
            compatible = "arm,arm1176-pmu";
        };

Kevin

[1] https://kernelci.org/boot/id/57bb4d9259b514895348b564/



More information about the linux-arm-kernel mailing list