[PATCH] pinctrl: exynos: remove duplicate calls in irq handler

Krzysztof Kozlowski k.kozlowski at samsung.com
Mon Aug 15 23:04:09 PDT 2016


On 08/16/2016 01:58 AM, perr perr wrote:
>  ---- On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski <k.kozlowski at samsung.com> wrote ---- 
>  > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: 
>  > > Because chained_irq_enter() has already called chip->irq_mask() and 
>  > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), 
>  > > so it's not necessary to call chip->irq_*() here. 
>  > >  
>  > > Signed-off-by: perr <strongbox8 at zoho.com> 
>  > >  
>  > > --- 
>  > >  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- 
>  > >  1 file changed, 1 insertion(+), 5 deletions(-) 
>  > > 
>  >  
>  >  
>  > Looks correct so for the patch itself: 
>  > Reviewed-by: Krzysztof Kozlowski <k.kozlowski at samsung.com> 
>  >  
>  > However, your name "Perr" confuses me a little bit. For the 
>  > Signed-off-by statement, as mentioned in 
>  > Documentation/SubmittingPatches, a real name is required. The name 
>  > should match the author. 
>  >  
>  > Would you be so kind as to use a full, real name? Unless Perr is your 
>  > full, real name... then sorry for the trouble. 
> Perr Zhang <strongbox8 at zoho.com>  is OK?
> I'm from China. Perr is my first name in English.

Yes, seems fine. Could you resend with updated name?

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list