linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354: possible missing code ?

[Robert Jarzmik]

David Binderman <dcb314 at hotmail.com> writes:

> Hello there,
>
> linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354]: (style) Variable 'val' is assigned a value that is never used.
>
> Source code is
>
>     if ((1 << vdd) & p_d->ocr_mask)
>         val |= PCM990_CTRL_MMC2PWR;
>     else
>         val &= ~PCM990_CTRL_MMC2PWR;
>
>     pcm990_cpld_writeb(PCM990_CTRL_MMC2PWR, PCM990_CTRL_REG5);
>     return 0;
>
> Suggest either use local variable val or delete it.
Can you please submit a proper patch as in Documentation/SubmittingPatches ?

Cheers.

-- 
Robert