[PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup

Dinh Nguyen dinguyen at opensource.altera.com
Tue Apr 5 11:37:49 PDT 2016


On Tue, 5 Apr 2016, Borislav Petkov wrote:

> On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
> > I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
> > the next revision with a goto.
> 
> I'm assuming nothing else changes. Because I've applied 1-4 already.
> 
> Yes, no?
> 
> If no, then please send only an updated version of this patch as a reply
> to this thread here.
> 

My only suggestion was to change the 3 helper functions(ecc_set_bits,
ecc_clear_bits, and ecc_test_bits) should be static inline.

So with that change:

Acked-by: Dinh Nguyen <dinguyen at opensource.altera.com>

BR,
Dinh



More information about the linux-arm-kernel mailing list