[PATCH v3] dma: pl08x: allocate OF slave channel data at probe time

Johannes Stezenbach js at sig21.net
Mon Apr 4 07:31:46 PDT 2016


Hi Linus,

On Sun, Apr 03, 2016 at 09:01:19PM +0200, Linus Walleij wrote:
> The current OF translation of channels can never work with
> any DMA client using the DMA channels directly: the only way
> to get the channels initialized properly is in the
> dma_async_device_register() call, where chan->dev etc is
> allocated and initialized.
> 
> Allocate and initialize all possible DMA channels and
> only augment a target channel with the periph_buses at
> of_xlate(). Remove some const settings to make things work.
> 
> Cc: Maxime Ripard <maxime.ripard at free-electrons.com>
> Cc: Joachim Eastwood <manabian at gmail.com>
> Cc: Johannes Stezenbach <js at sig21.net>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> ChangeLog v2->v3:
> - Drop the patch and variable for fixed signal assignment.
> - Always assign a fixed channel number when registering
>   the channels.

Your patch looks good, and I just tested it and
it also works :-)  Perfect!


Thanks,
Johannes



More information about the linux-arm-kernel mailing list