[RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs.

Arnd Bergmann arnd at arndb.de
Tue Sep 29 00:42:48 PDT 2015


On Monday 28 September 2015 17:56:24 David Daney wrote:
> From: David Daney <david.daney at cavium.com>
> 
> Early versions of the Cavium Thunder CN88XX processor are missing
> Enhanced Allocation (EA) capabilities for the fixed BAR addresses used
> by the on-SoC hardware blocks.
> 
> Add config access functions that synthesize the missing EA
> capabilities for versions that are missing that information.  Since
> this is a little hacky, gate the inclusion of the code with a new
> Kconfig variable.
> 
> Signed-off-by: David Daney <david.daney at cavium.com>
> ---
> 
> As suggested by Bjorn Helgaas...  It is RFC at this point, but this is
> working well for me.

I don't have an opinion on the way you implement the config space
accessors, but it seems that the overall amount of code is comparable
to the normal pci-host-generic driver without this, and it is not
really generic at all.

I think because of this, it makes more sense to have a separate top-level
driver for this and not reuse the pci-host-generic implementation here.

	Arnd



More information about the linux-arm-kernel mailing list