[PATCH v4 1/4] edac: Export edac_debugfs

Loc Ho lho at apm.com
Tue Sep 22 10:46:07 PDT 2015


Hi,

>> This patch exports and expose the edac_debugfs file node. This allows
>> EDAC driver to create debugfs node under the EDAC debugfs node.
>
> ...
>
>> -#ifdef CONFIG_EDAC_DEBUG
>> -static struct dentry *edac_debugfs;
>> +struct dentry *edac_debugfs;
>> +EXPORT_SYMBOL_GPL(edac_debugfs);
>
> Hmm, so Arnd was right about this being the wrong direction we're
> chasing. We should rather be exporting a bunch of EDAC debugfs wrappers
> which EDAC drivers can call instead of exposing edac_debugfs itself.
>
> And this is much better and the right(tm) approach IMO. So I went
> and hacked it in, it builds on those !x86 targets (as far as my
> cross-compilers are concerned, build succeeds :-)).
>
> So here it is as a follow-up to this message.

Let's me sync and give it a try. Do you see any other issue besides this?

-Loc



More information about the linux-arm-kernel mailing list