[PATCH v2 1/3] ARM: mvebu: add DT support for Seagate NAS 2 and 4-Bay

Andrew Lunn andrew at lunn.ch
Tue Sep 22 08:09:52 PDT 2015


On Fri, Sep 11, 2015 at 11:52:51PM +0200, Simon Guinot wrote:
> From: Vincent Donnefort <vdonnefort at gmail.com>
> 
> This patch adds DT support for the Seagate NAS 2 and 4-Bay.
> 
> Here are some informations allowing to identify these devices:
> 
> Product name                 | Seagate NAS 2-Bay | Seagate NAS 4-Bay
> Code name (board/PCB)        | Dart 2-Bay        | Dart 4-Bay
> Model name (case sticker)    | SRPD20            | SRPD40
> Material desc (product spec) | STCTxxxxxxx       | STCUxxxxxxx

Hi Simon

Thanks for adding this information.

> +	gpio-fan {
> +		compatible = "gpio-fan";
> +		gpios = <&gpio2 0 0
> +			 &gpio2 1 0>;
> +	};

Minor nit-pick

GPIO_ACTIVE_HIGH could be used here. Other than that:

Acked-by: Andrew Lunn <andrew at lunn.ch>

for the whole series.

	  Andrew



More information about the linux-arm-kernel mailing list