[RFC PATCH v4 3/4] arm64: fix a migrating irq bug when hotplug cpu

Will Deacon will.deacon at arm.com
Thu Sep 17 09:01:07 PDT 2015


On Thu, Sep 17, 2015 at 06:19:25AM +0100, Yang Yingliang wrote:
> When cpu is disabled, all irqs will be migratged to another cpu.
> In some cases, a new affinity is different, it needed to be coppied
> to irq's affinity. But if the type of irq is LPI, it's affinity will
> not be coppied because of irq_set_affinity's return value. Fix it by
> using irq_do_set_affinity.
> 
> And migrating interrupts is a core code matter, so use the generic
> function move_irqs() to migrate interrupts in kernel/irq/migration.c.
> 
> Cc: Jiang Liu <jiang.liu at linux.intel.com>
> Cc: Thomas Gleixner <tglx at linutronix.de>
> Cc: Marc Zyngier <marc.zyngier at arm.com>
> Cc: Mark Rutland <mark.rutland at arm.com>
> Cc: Will Deacon <will.deacon at arm.com>
> Cc: Russell King - ARM Linux <linux at arm.linux.org.uk>
> Cc: Hanjun Guo <hanjun.guo at linaro.org>
> Signed-off-by: Yang Yingliang <yangyingliang at huawei.com>
> ---
>  arch/arm64/Kconfig           |  1 +
>  arch/arm64/include/asm/irq.h |  1 -
>  arch/arm64/kernel/irq.c      | 62 --------------------------------------------
>  arch/arm64/kernel/smp.c      |  2 +-
>  4 files changed, 2 insertions(+), 64 deletions(-)

Removing code is always good, so:

  Acked-by: Will Deacon <will.deacon at arm.com>

but obviously this depends on the core stuff.

Will



More information about the linux-arm-kernel mailing list