[PATCH 2/2] ARM: dts: rockchip: Add dtb for the Radxa Rock 2 Square board

Javier Martinez Canillas javier at dowhile0.org
Mon Sep 14 00:50:20 PDT 2015


Hello Sjoerd,

On Mon, Sep 14, 2015 at 9:30 AM, Sjoerd Simons
<sjoerd.simons at collabora.co.uk> wrote:

[snip]

>> > +
>> > +                       vcc18_lcd: REG12 {
>> > +                               regulator-name = "VCC18_LCD";
>> > +                               regulator-min-microvolt =
>> > <1800000>;
>> > +                               regulator-max-microvolt =
>> > <1800000>;
>> > +                               regulator-always-on;
>> > +                       };
>>
>> Should all these regulators really need to be always-on?
>
> Ideally not all of them, turning the ones that aren't needed off is
> definately on my list of things to do (together with the other
> pheripherals, leds, hw. keys etc).
>
> For the first patch i do prefer to keep them on so we can have get some
> more testing  with this board before fine-tuning those things (fwiw,

Ok.

> the rockchip evb board and others with essentially the same pmic setup
> all also have them always-on)

Yes but I believe that's because it was easier and there are
regulators on these boards that don't need to be always-on as well.

> --
> Sjoerd Simons
> Collabora Ltd.

Best regards,
Javier



More information about the linux-arm-kernel mailing list