[PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node
horms at verge.net.au
Fri Oct 30 00:25:47 PDT 2015
On Fri, Oct 30, 2015 at 04:17:46PM +0900, Simon Horman wrote:
> On Thu, Oct 29, 2015 at 05:42:43PM +0900, Magnus Damm wrote:
> > On Thu, Oct 15, 2015 at 3:48 PM, Simon Horman
> > <horms+renesas at verge.net.au> wrote:
> > > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks at renesas.com>
> > >
> > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks at renesas.com>
> > > [horms: minor updates]
> > > Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> > > Acked-by: Geert Uytterhoeven <geert+renesas at glider.be>
> > Hi Simon,
> > Thanks for your efforts with the ethernet controller. In general all
> > seems good to me, but this I came across the contents of this patch
> > when I was browsing the SoC DTSI file. What is the reason to put this
> > node in between dmac0 and dmac1? I don't know where is the best
> > location, but it would be good to keep the dmac nodes together I
> > think.
> I think its just an artifact of the way the patch has been updated.
> I'll see about cleaning it up.
On slightly closer inspection it seems to be there due to sorting
by base address. But it seems rather silly the way it is so I have it
in mind to shuffle it down below the dmac nodes.
More information about the linux-arm-kernel