[patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()

Dan Carpenter dan.carpenter at oracle.com
Thu Oct 22 12:52:08 PDT 2015

The "domain" variable needs to be signed for the error handling to work.

Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 2c3b16f..de5e89b 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;
 static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
-	u8 domain = topology_physical_package_id(cpu_dev->id);
+	int domain = topology_physical_package_id(cpu_dev->id);
 	if (domain < 0)
 		return ERR_PTR(-EINVAL);

More information about the linux-arm-kernel mailing list