[PATCH RFC] arm64/ftrace: Define a new arm64 trace clock source based on cntpct_el0 register.

Steven Rostedt rostedt at goodmis.org
Wed Oct 21 08:52:43 PDT 2015

On Wed, 21 Oct 2015 21:07:04 +0530
Amit Tomer <amittomer25 at gmail.com> wrote:

> Thank you for looking into it and providing your comments.
> >> +       [local] global counter x86-tsc arm64-pct
> >
> > You don't need to update this line. You can't have both x86-tsc and
> > arm64-pct at the same time.
>   Ok, I understand. But is there a nice way to put it, something like
> x86-tsc/arm64-pct/... ?

No, it's just an example. No need to update it.

> > Why is this a define and not a static inline?
> There is no specific reason to it . I would change it to static inline.

Please do. static inline is preferred over defines. We only use defines
when a static inline wont work for the needed operation.

-- Steve

More information about the linux-arm-kernel mailing list