[PATCH] EDAC: Add AMD Seattle SoC EDAC
mark.rutland at arm.com
Tue Oct 20 10:26:55 PDT 2015
On Tue, Oct 20, 2015 at 06:57:44PM +0200, Borislav Petkov wrote:
> On Tue, Oct 20, 2015 at 11:44:46AM -0500, Brijesh Singh wrote:
> > > This second property doesn't describe the hardware in any way. It should
> > > be runtime-configurable and dpesn't belong in the DT.
> > >
> > > Regardless, the binding is wrong. This is in no way specific to AMD
> > > Seattle, and per the code is actually used to imply the presence of a
> > > Cortex-A57 feature. No reference to AMD Seattle belongs in the DT
> > > binding (with the exception of the example, perhaps), nor in the driver.
> > >
> > > NAK while this pretends to be something that it isn't. At minimum, you
> > > need to correctly describe the feature you are trying to add support
> > > for.
> > >
> > I will remove AMD specific string in compatibility field and make
> > the poll-delay-msec optional. Will also expose this as module
> > parameter as you suggested below.
> Btw, how much of this is implementing generic A57 functionality?
The driver is entirely A57 generic.
> If a lot, can we make this a generic a57_edac driver so that multiple
> vendors can use it?
> How fast and how ugly can something like that become?
Not sure I follow.
More information about the linux-arm-kernel