[PATCH] hwrng: exynos - Fix unbalanced PM runtime get/puts

Krzysztof Kozlowski k.kozlowski at samsung.com
Sun Oct 18 18:41:12 PDT 2015

On 17.10.2015 01:01, Daniel Thompson wrote:
> Currently this driver calls pm_runtime_get_sync() rampantly
> but never puts anything back. This makes it impossible for the
> device to autosuspend properly; it will remain fully active
> after the first use.
> Fix in the obvious way.
> Signed-off-by: Daniel Thompson <daniel.thompson at linaro.org>
> Cc: Kukjin Kim <kgene at kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> ---
> Notes:
>     Compile tested only (CONFIG_PM=y, CONFIG_HW_RANDOM_EXYNOS=m); I spotted
>     this whilst reviewing the code and don't have an exynos platform to
>     test on.
>  drivers/char/hw_random/exynos-rng.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

To test the patch I had to add OF support to the driver. I have these
patches almost ready and I will send them soon. Anyway:

Tested on Trats2 board (Exynos4412):
Tested-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>

Reviewed-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>

Best regards,

More information about the linux-arm-kernel mailing list