[PATCH v4] iommu/arm-smmu: Add support for MSI on SMMUv3

Mark Rutland mark.rutland at arm.com
Tue Oct 13 11:48:29 PDT 2015


> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt
> @@ -36,5 +36,25 @@ the PCIe specification.
>                        NOTE: this only applies to the SMMU itself, not
>                        masters connected upstream of the SMMU.
>  
> +- msi-parent	    : phandles (and potential Device IDs) of MSI controllers


For correct terminology, I'd prefer to replace this line with:

- msi-parent: a list of phandle + msi-specifier pairs for MSI controllers

An msi-specifier may be zero cells, per
Documentation/devicetree/bindings/interrupt-controller/msi.txt, much
like other *-specifiers.

> +		      the SMMU can send MSIs to (instead of wired interrupts).
> +		      See devicetree/bindings.interrupt-controller/msi.txt
> +		      for a description of the msi-parent property.

The rest of this is fine, modulo the '.' which should be a '/'. in the
path.

With those changes:

Acked-by: Mark Rutland <mark.rutland at arm.com>

Thanks,
Mark.



More information about the linux-arm-kernel mailing list