[PATCH 15/37] ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Oct 12 14:12:44 PDT 2015


The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 arch/arm/boot/dts/imx23-stmp378x_devb.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Cc: Shawn Guo <shawnguo at kernel.org>
Cc: Sascha Hauer <kernel at pengutronix.de>

diff --git a/arch/arm/boot/dts/imx23-stmp378x_devb.dts b/arch/arm/boot/dts/imx23-stmp378x_devb.dts
index 455169e99d49..928f5556ae7b 100644
--- a/arch/arm/boot/dts/imx23-stmp378x_devb.dts
+++ b/arch/arm/boot/dts/imx23-stmp378x_devb.dts
@@ -10,6 +10,7 @@
  */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "imx23.dtsi"
 
 / {
@@ -75,7 +76,7 @@
 			regulator-name = "vddio-sd0";
 			regulator-min-microvolt = <3300000>;
 			regulator-max-microvolt = <3300000>;
-			gpio = <&gpio1 29 0>;
+			gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
 		};
 	};
 };
-- 
2.4.9




More information about the linux-arm-kernel mailing list