[PATCH] ARM: OMAP2+: Fixed inverted OMAP_OFFOUT_EN

Tony Lindgren tony at atomide.com
Thu Oct 8 23:40:06 PDT 2015

* Ben Tucker <benjamint at bsquare.com> [151008 06:09]:
> The OFFOUTENABLE bit of the omap PADCONF registers is active low.
> The mux code assumed that it was active high and this patch fixes this
> problem.
> Tested on an AM37x device.

Hmm what are the test cases you're using to validate this so
I can try to reproduce?

AFAIK because of erratum 1.158 for GPIO pins needing to be
muxed temporarly for input + pull + safe mode for off mode,
so I'm wondering in which cases the OFFOUTENABLE can be used.

I have a patch in works for 1.158 using gpio-ranges, and the
test case I'm using is the reset of WLAN that happens in off
mode as the enable GPIO glitches when returning from off mode.

Also.. I'm wondring why this has not been caught earlier?
Maybe because 1.158 is needed on omap3?



More information about the linux-arm-kernel mailing list