[PATCH v4 3/5] PCI: generic: Quit clobbering our pci_ops.
arnd at arndb.de
Thu Oct 8 08:09:56 PDT 2015
On Thursday 08 October 2015 10:02:16 Bjorn Helgaas wrote:
> [+cc Arnd]
> Arnd, you had comments on the previous version. What do you think of
> this one?
Looks good to me
> On Fri, Oct 02, 2015 at 11:44:01AM -0700, David Daney wrote:
> > From: David Daney <david.daney at cavium.com>
> > The pci-host-generic driver keeps a global struct pci_ops which it
> > then patches with the .map_bus method appropriate for the bus device.
> > A problem arises when the driver is used for two different types of
> > bus devices, the .map_bus method for the last device probed clobbers
> > the method for all previous devices. The result, only the last bus
> > device probed has the proper .map_bus, and the others fail.
> > Move the struct pci_ops into the bus specific structure, and
> > initialize a pointer to it when the bus device is probed.
> > Acked-by: Will Deacon <will.deacon at arm.com>
> > Signed-off-by: David Daney <david.daney at cavium.com>
Reviewed-by: Arnd Bergmann <arnd at arndb.de>
More information about the linux-arm-kernel