[PATCH] ARM: shmobile: alt: Add pfc pins to DT

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Fri Nov 20 10:50:08 PST 2015


On 11/20/2015 09:34 PM, Simon Horman wrote:

>>> PFC is already enabled on the r8a7794.
>>> This adds pins for devices already enabled in DT on
>>> the r8a7794 based alt board.
>>>
>>> Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
>>>
>>> Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc at renesas.com>
>>> Cc: Hisashi Nakamura <hisashi.nakamura.ak at renesas.com>
>>> Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
>>>
>>> ---
>>> Tested
>>> ---
>>>   arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
>>>   1 file changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
>>> index 928cfa641475..2e889991ce8f 100644
>>> --- a/arch/arm/boot/dts/r8a7794-alt.dts
>>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts
>>> @@ -39,6 +39,23 @@
>>>   	clock-frequency = <20000000>;
>>>   };
>>>
>>> +&pfc {
>>> +	scif2_pins: serial2 {
>>> +		renesas,groups = "scif2_data";
>>> +		renesas,function = "scif2";
>>> +	};
>>> +
>>> +	ether_pins: ether {
>>> +		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
>>> +		renesas,function = "eth";
>>> +	};
>>> +
>>> +	ether_b_pins: ether {
>>> +		renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
>>> +		renesas,function = "eth";
>>> +	};
>>> +};
>>> +
>>>   &cmt0 {
>>>   	status = "okay";
>>>   };
>>
>>     Why add unreferenced pins? How have you tested this?
>
> Thanks for pointing out that oversight. I'll see about filling in the gaps.

    Sorry for noticing this too late, only when you were pushing your branches 
upstream...

MBR, Sergei




More information about the linux-arm-kernel mailing list