[PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx
broonie at kernel.org
Tue Nov 17 14:52:00 PST 2015
On Tue, Nov 17, 2015 at 11:21:12AM -0800, Joshua Clayton wrote:
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.
> It takes some clutter out of main() whose scope is limited to that little block of code,
> and because in the next patch we add another (larger)function to the if/else block.
> I don't know if it is valid to say "look at the next commit" for justification, but
> That is the reason.
That's totally fine - just say that it's to support future changes in
this area. It's good to split out mechanical changes like this from the
more complex changes, you just need to say why they're happening.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 473 bytes
Desc: not available
More information about the linux-arm-kernel